Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Extend the merge rollup task capabilities #14355

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

davecromberge
Copy link
Member

Merge rollup task feature enhancement

Adds the capability to erase dimension values from a merged segment before rollup to reduce cardinality and increase the degree to which common dimension coordinates are aggregated. This can result in a space saving for some dimensions which are not important in historic data.

See: #14310

release-notes:

  • New configuration options

@codecov-commenter
Copy link

codecov-commenter commented Nov 1, 2024

Codecov Report

Attention: Patch coverage is 91.17647% with 3 lines in your changes missing coverage. Please review.

Project coverage is 63.79%. Comparing base (59551e4) to head (b604850).
Report is 1273 commits behind head on master.

Files with missing lines Patch % Lines
...n/tasks/mergerollup/DimensionValueTransformer.java 86.36% 2 Missing and 1 partial ⚠️
Additional details and impacted files
@@             Coverage Diff              @@
##             master   #14355      +/-   ##
============================================
+ Coverage     61.75%   63.79%   +2.04%     
- Complexity      207     1566    +1359     
============================================
  Files          2436     2661     +225     
  Lines        133233   145935   +12702     
  Branches      20636    22338    +1702     
============================================
+ Hits          82274    93105   +10831     
- Misses        44911    45956    +1045     
- Partials       6048     6874     +826     
Flag Coverage Δ
custom-integration1 100.00% <ø> (+99.99%) ⬆️
integration 100.00% <ø> (+99.99%) ⬆️
integration1 100.00% <ø> (+99.99%) ⬆️
integration2 0.00% <ø> (ø)
java-11 63.75% <91.17%> (+2.04%) ⬆️
java-21 63.69% <91.17%> (+2.07%) ⬆️
skip-bytebuffers-false 63.77% <91.17%> (+2.03%) ⬆️
skip-bytebuffers-true 63.66% <91.17%> (+35.94%) ⬆️
temurin 63.79% <91.17%> (+2.04%) ⬆️
unittests 63.79% <91.17%> (+2.04%) ⬆️
unittests1 55.51% <ø> (+8.62%) ⬆️
unittests2 34.16% <91.17%> (+6.43%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Adds the capability to erase dimension values from a merged segment
before rollup to reduce cardinality and increase the degree to which
common dimension coordinates are aggregated.  This can result in a
space saving for some dimensions which are not important in historic
data.

See: apache#14310
@davecromberge davecromberge force-pushed the feature/extend-merge-rollup-capabilities-1 branch from 77b3e0e to b604850 Compare November 1, 2024 10:29
@Jackie-Jiang Jackie-Jiang added enhancement release-notes Referenced by PRs that need attention when compiling the next release notes Configuration Config changes (addition/deletion/change in behavior) ingestion minion labels Nov 17, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Configuration Config changes (addition/deletion/change in behavior) enhancement ingestion minion release-notes Referenced by PRs that need attention when compiling the next release notes
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants